chore: improve calculation of optimism l1 fee #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npty
force-pushed
the
chore/adjust-l1-fees-optimism
branch
from
4c4a48e to
6474d3a
Compare
canhtrinh
approved these changes
Mar 14, 2024
canhtrinh
added a commit
that referenced
this pull request
Mar 20, 2024
* chore: improve calculation of optimism l1 fee (#309) * chore: improve calculation of optimism l1 fee * chore: fix tests * 0.15.0-alpha.4 * chore: fix tests * chore: return 0 for mantle L1 fee (#310) * 0.15.0-alpha.5 * chore: update changelog * 0.15.0 * chore: fix test --------- Co-authored-by: npty <[email protected]> Co-authored-by: npty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
l1_gas_used*l1_gas_pricetol1_gas_fee(query directly from GasOracle contract). I found that this way returns more accurate l1 fee compare to a random tx on optimis blockexplorerexecutionFeeWithMultipliertoexecutionFeefieldl1ExecutionFeeWithMultiplier